Sam Carré
Sam Carré
Awesome, makes total sense! The ability for it to be queued would be really handy - but now that it's in a terminatable middleware I don't know how beneficial it...
Hey @bilfeldt I would quite like to get my hands on this feature without using a fork, so if you are okay making the other changes, I won't build the...
Not yet, but I was thinking of swapping it to a fork today as the team would really benefit from the performance improvement. I'm going to need to swap the...
Hey @bilfeldt I hope you are well! I was wondering if it would be possible to go through this PR again? I would love to have this feature in the...
Unfortunately I don't think I have time to finish this PR so I will be closing this
Hey @bilfeldt I'm really sorry for not replying sooner - I feel awful! Thank you for such a detailed reply. It would be great if this was a feature in...
No, the middleware isn't terminatable - so it'll be part of the request - this is why it's being picked up in the request lifecycle
Hmm, the listener isn't queued so that leaves me to think it might be running synchronously? I might be wrong - where abouts is the `RequestHandled` event being fired?
Sorry - I didn't realise it was a Laravel event: https://github.com/laravel/framework/blob/988206bcacf79829bda66af4a016778e4b4d762a/src/Illuminate/Foundation/Http/Kernel.php#L152 But it doesn't look like this is after the request lifecycle. I'll keep digging haha
So looking in `public/index.php` it looks like `handle` is run to create the response (and fire the `RequestHandled` event) and then the `terminate` method is run after, which runs the...