Sam Carré

Results 127 comments of Sam Carré

Hey @onlime I'm very sorry for not replying to this PR sooner - when I get a chance over the next day or two I will review this properly -...

Hey @onlime thank you for the wait, unfortunately I want to try and keep Saloon as minimal as possible and offering multiple ways to set the endpoint isn't something I...

Ah, I just figured out another potential bug with the keys. For example if you have two different nodes that both have child nodes, the keys aren't reset so you...

With the latest commit: ![Screen Shot 2021-05-09 at 17 15 31](https://user-images.githubusercontent.com/29132017/117579301-2a183f00-b0ea-11eb-972d-806074101772.png)

Hey @SDJeff! This is the expected behaviour - when there are multiple child elements with the same name, the library will decode it into an array of values. If you...

Hey @bilfeldt This is my initial PR for the fix - would love to see what you think

Hey @bilfeldt I have updated the PR to use terminatable instead. The application will now run the `LogHandler` while it is being terminated, which will record the request logs. Nice...

Hey @bilfeldt would you mind if I changed this PR to work for v2? We're having issues upgrading to v3. Update: I think it might just be worth seeing why...

Hey @bilfeldt I have added a feature test which makes an API call and checks that the terminatable middleware is working. I introduced a new `ArrayLogger` driver which is bound...

Thanks @bilfeldt - glad you like it! Would it be a breaking change if this were merged into v3? In my opinion from working in open source, we're only modifying...