Sam Carré comments

Results 127 comments of


                                            Sam Carré

Adding hasRequestFailed() method to connector always throws an exception

I believe you just need to flip around the logic from true to false, if the `hasRequestFailed` returns true, then Saloon thinks the request has failed.

feat(testing): accept type-hinted requests as `assertSent` parameters

Thank you for this PR ✅

Recommended Laravel Telescope integration after laravel-http-sender deprecation

Hey @dtvmedia I'd be happy to accept a PR to implement telescope support in the Laravel Plugin.

Recommended Laravel Telescope integration after laravel-http-sender deprecation

Hey @JonPurvis one for us to discuss next week!

Add PSR-20 Clock Support

The code looks good @yankewei - and I quite like the idea of it. If you could give me a couple more weeks I will get round to reviewing properly.

Add Macroable to Request?

Hey @aarondfrancis just wanted to first off say a huge apology for not seeing your issue sooner, life is so. so. busy at the moment. Thank you for the love...

Allow partial mocking

Thanks for the idea @epixian I quite like the idea too - perhaps you could initiate it by using `Saloon::fake()->partial()` or `new PartialMockClient` perhaps?