Sam Carré

Results 127 comments of Sam Carré

Hey @kamilpiech97 thanks for this, sorry for the delay in responding! I agree there's times where `git` isn't available - I would be happy to write a quick try-catch and...

This is a very very strange one, I wrote a test to replicate this issue and the XML string that XML Wrangler created looked correct, however when I tried to...

I believe the writer uses `spatie/array-to-xml` and `veewee/xml` is solely used for reading. Still a very strange issue, because my direct output showed it looked fine, but PEST had the...

Hey @zainavrillo534102 thanks for raising this issue with me. I have also found this happen when the XML is slightly invalid, or if you want to parse a subset of...

Thank you for the very quick reply! Noted about the HTML - I kind of assumed because it looked XML-ish, the reader would understand it, but I won't try and...

Hey @Gummibeer - thanks for this PR, and sorry for the delay, life has been really busy. I will have a look through this and hopefully soon we can merge...

@Gummibeer Seems like something is up with the tests 🤔 Obviously no rush but if you get a spare 5 minutes it'll be good if you could take a look...

I'm going to have a Saloon day this weekend so I'll merge it then, thanks for the patience!

Thanks @fredbradley I will take a look soon and see if I can potentially refactor this to be trait-style like the other OAuth2 implementations, unless you want to give it...

Hey @fredbradley any further thoughts on moving to a trait?