eipw icon indicating copy to clipboard operation
eipw copied to clipboard

Missing `last-call-deadline` should not create an annotation

Open Pandapip1 opened this issue 2 years ago • 2 comments

This is automagically assigned by the review bot now, meaning that a missing last call deadline should block the PR, but shouldn't display an annotation.

Pandapip1 avatar Mar 23 '23 12:03 Pandapip1

Just to confirm what you want here, should eipw return a zero exit code (indicating success) or a non-zero exit code (indicating failure) when last-call-deadline is missing?

SamWilsn avatar Apr 15 '23 16:04 SamWilsn

I would like it to fail, but to create either an info-type annotation or no annotation whatsoever.

Pandapip1 avatar Apr 17 '23 17:04 Pandapip1