Saumya Bhatnagar

Results 14 comments of Saumya Bhatnagar
trafficstars

@oblador for zoom, consider looking at this library https://github.com/alwx/react-native-photo-view.

Nice, just noticed the last commit... 0fcd510530525c0809fa51b0914243c757b89697 has already been merged.

maybe try again.. I can see your branch not up-to-date with master https://github.com/saketkumar95/zulip-android/commits/patch-21-login

@saketkumar95 thanks for working on this! 👍 One issue: I noticed the shadow under the toolbar and menu in zulipActivity are lost.

@saketkumar95 also can you resolve the merge conflicts?

@saketkumar95 this pr is really good and almost ready to merged. If the above comments could be addressed, this can be merged soon 👍.

@vishwesh3 thanks for working on this! 👍 Faced one issue: When I tried the changes, on switching the theme, the load position of message is not maintained in the narrow....

@vishwesh3 this looks great! 👍 Though I am still facing the load position bug on switching theme for a stream. Here's a short video https://drive.google.com/open?id=0B4jK5QX65b0ZbzZoR1BvVjd1M1E Also noticed a typo in...

hmm.. I think on small screen devices this can be a problem. @kunall17 what are your thoughts on this?

@zeerorg this looks great! 👍 Can you please address Saket's comment here?