zulip-android-legacy icon indicating copy to clipboard operation
zulip-android-legacy copied to clipboard

Published 20 hours ago • verified publisher icon zulip

Fix minor bug in AutoCompleteTextView

Open yadav-rahul opened this issue 8 years ago • 6 comments

This PR fixes limits maxLines in Stream's AutoCompleteTextView to 1.

  • Without this property, AutoCompleteTextView can display multiple lines at a time and thus giving poor User experience.

Before rsz_stream

Now, it will work fine because maxLines are limited to one.

yadav-rahul avatar Jan 30 '17 21:01 yadav-rahul

Automated message from Dropbox CLA bot

@yadav-rahul, it looks like you've already signed the Dropbox CLA. Thanks!

smarx avatar Jan 30 '17 21:01 smarx

hmm.. I think on small screen devices this can be a problem. @kunall17 what are your thoughts on this?

Sam1301 avatar Jan 31 '17 09:01 Sam1301

Actually Topic's AutoCompleteTextView already has this property(android:maxLines="1"). Implementing same in Stream's AutoCompleteTextView would look better :)

@kunall17 What are your views on it?

yadav-rahul avatar Jan 31 '17 12:01 yadav-rahul

@timabbott @kunall17 Please review this PR :)

yadav-rahul avatar Jan 31 '17 18:01 yadav-rahul

Mostly the stream wouldn't be of more that 15 chars which means 2-3 lines (At the max) and by providing maxlines it would hide the text and giving 1 line more doesn't look that bad!

kunall17 avatar Jan 31 '17 18:01 kunall17

I could imagine rebalancing a bit how much space each of stream and topic get in that line (or giving each their own line)

timabbott avatar Jan 31 '17 19:01 timabbott