zulip-android-legacy
zulip-android-legacy copied to clipboard
Add tutorial sliders for first time launch of app
Summary of changes
Fixes https://github.com/zulip/zulip-android/issues/161
Please make sure these boxes are checked before submitting your pull request - thanks! Guide
-
[x] Code is formatted.
-
[x] Run the lint tests with
./gradlew lintDebug
and make sure BUILD is SUCCESSFUL -
[x] If new feature is implemeted then it is compatible with Night theme too.
-
[x] Commit messages are well-written.
@vishwesh3 yeah i tried same the first time but all layouts have different sizes and of imagview and paddings so it is difficult to have same dimensions in all the 4 layouts
@saketkumar95 How about using the App intro Library Material AppIntro? Both look the same but It would cut down on the lines of code. :)
@nitish1211 The library looks awesome but we are using simple intro slides and i just used 1 class and 4 layouts so it doesn't make sense for using library for that only. We already have lots of library and apk size is already high right now. :)
Anyone Working on this ?
I want to work on ViewPager and add Multiple instances of Fragment instead of 4 Different Layouts.
@saketkumar95 thanks for working on this! 👍
One issue: I noticed the shadow under the toolbar and menu in zulipActivity are lost.
@saketkumar95 I would want to merge this, can you fix the comments posted by saumya?
@kunall17 Yeah i will do this in 1-2 days, currently busy in my lab exams. :/
@saketkumar95, your pull request has developed a merge conflict! Please review the most recent commit (f791888) for conflicting changes and resolve your pull request's merge conflicts.