zulip-android-legacy icon indicating copy to clipboard operation
zulip-android-legacy copied to clipboard

Add tutorial sliders for first time launch of app

Open saketkumar opened this issue 7 years ago • 8 comments

Summary of changes

Fixes https://github.com/zulip/zulip-android/issues/161

Please make sure these boxes are checked before submitting your pull request - thanks! Guide

  • [x] Code is formatted.

  • [x] Run the lint tests with ./gradlew lintDebug and make sure BUILD is SUCCESSFUL

  • [x] If new feature is implemeted then it is compatible with Night theme too.

  • [x] Commit messages are well-written.

saketkumar avatar Mar 12 '17 05:03 saketkumar

@vishwesh3 yeah i tried same the first time but all layouts have different sizes and of imagview and paddings so it is difficult to have same dimensions in all the 4 layouts

saketkumar avatar Mar 12 '17 10:03 saketkumar

@saketkumar95 How about using the App intro Library Material AppIntro? Both look the same but It would cut down on the lines of code. :)

nitish1211 avatar Mar 12 '17 18:03 nitish1211

@nitish1211 The library looks awesome but we are using simple intro slides and i just used 1 class and 4 layouts so it doesn't make sense for using library for that only. We already have lots of library and apk size is already high right now. :)

saketkumar avatar Mar 13 '17 03:03 saketkumar

Anyone Working on this ?

I want to work on ViewPager and add Multiple instances of Fragment instead of 4 Different Layouts.

meghalagrawal avatar Mar 21 '17 17:03 meghalagrawal

@saketkumar95 thanks for working on this! 👍

One issue: I noticed the shadow under the toolbar and menu in zulipActivity are lost.

Sam1301 avatar Mar 27 '17 04:03 Sam1301

@saketkumar95 I would want to merge this, can you fix the comments posted by saumya?

kunall17 avatar Apr 08 '17 11:04 kunall17

@kunall17 Yeah i will do this in 1-2 days, currently busy in my lab exams. :/

saketkumar avatar Apr 08 '17 11:04 saketkumar

@saketkumar95, your pull request has developed a merge conflict! Please review the most recent commit (f791888) for conflicting changes and resolve your pull request's merge conflicts.

zulipbot avatar May 04 '17 18:05 zulipbot