Simon Pearce

Results 276 comments of Simon Pearce

> @famosab if you want to suggest those changes I will accept them - that way your commit is tracked. > > Otherwise LMK if you want me to just...

Also you should remove the entry in the `tests/config/pytest_modules.yml` file to stop the pytest from running.

@tobsecret , multiqc has now been updated to v1.30, hopefully that solves your issue.

Also, can the tool work on cram files?

Thank you, I'll stop being nitpicky now ;)

> [@SPPearce](https://github.com/SPPearce) Any ideas on the ASCAT error? Is that related to other errors that we see or does this need some kind of parabricks fix? Probably just an issue...

@homonecloco , do you still want to implement this?

Hi, What is the reason for this PR? [Modules should generally](https://nf-co.re/docs/guidelines/components/modules#optional-command-arguments) just use `task.ext.args` to pass optional arguments directly to the tool.

Yes, `task.ext.args` is typically just a string (there is one module I can think of which passes it as a list, but that is non-standard). The type checking is normally...