Ryan Foster
Ryan Foster
This could use further review, particularly on the struct changes, but generally on everything because I've never had to touch these files before. This could also use further testing.
Fixing clang-format complaint, hopefully.
cc @Lain-B and @derrod on the breaking changes concern raised by @norihiro My initial and primary concern was working out an update to an outdated vendored dependency. If there are...
Rebased and made the warning suppression more targeted. Will probably need @Lain-B to comment on the ABI breakage concern.
I believe the proposal during triage was that this should be marked as deprecated/experimental to indicate that it is a stopgap solution until a more complete solution can be produced....
> Shall I open new issues or how do we want to handle that? If they still occur after this PR, then feel free to submit new Issues.
> https://github.com/obsproject/obs-studio/blob/60a45d3aa3b5900216f0e069e5af901d93013307/plugins/linux-pipewire/pipewire.c#L396-L397 > is the only place where it can happen. I guess the question is whether or not `obs_pw_stream->format_info.num` is expected to be `0` at times, and if so,...
> > I guess the question is whether or not `obs_pw_stream->format_info.num` is expected to be `0` at times, and if so, should we be calling `bzalloc` when it is? >...
Let's merge this to see how loud it is.
Building this on Windows 11 and running with a fresh installation in Portable Mode results in a crash on startup:  ``` KernelBase.dll!00007ffd125bfabc() Unknown vcruntime140d.dll!00007ffc2d8c9362() Unknown > obs64.exe!std::filesystem::_Throw_fs_error(const char *...