obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard

Add Missing Encoder Check on Startup/Profile load

Open derrod opened this issue 1 year ago • 5 comments

Description

Adds additional checks to the nvenc test binary, and uses it to show a descriptive error message on startup if NVENC was selected and is now missing.

Example: Example Warning Screenshot

Motivation and Context

Want to make it more obvious to users why NVENC has gone missing, especially those with Kepler GPUs.

How Has This Been Tested?

Tested with modifications to the nvenc test binary to produce various error codes.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

derrod avatar Oct 03 '24 17:10 derrod

I'd like to adjust the formatting of this a little bit to group the errors with the encoder it's for


There were errors with one or more encoders:

obs_nvenc_hevc_tex

NVENC check failed with reason: Outdated driver (code: outdated_driver)

obs_nvenc_another

Miscellaneous probme (code: bad_nibbles)

See the Knowledge Base Article for further information



<li>
<h3></h3>
<code><code>
</li>

Warchamp7 avatar Oct 21 '24 21:10 Warchamp7

Updated it based on that, looks like this now:

screenshot revised

derrod avatar Nov 01 '24 00:11 derrod

Updated it based on that, looks like this now:

screenshot revised

Looks good aside from the code: outdated_driver getting double reported on the NVENC entries. Is NVENC including that as part of their error message?

Warchamp7 avatar Nov 18 '24 21:11 Warchamp7

Yeah the error string for NVENC originally included the code as well and I forgot to remove that.

See https://github.com/obsproject/obs-studio/pull/11340/files#diff-cd50d66da1e02db4fa473b80d6109b5799b4e619d09ac4e4487e4492ded51fc8R1604

derrod avatar Nov 18 '24 22:11 derrod

This has a merge conflict.

RytoEX avatar Aug 28 '25 20:08 RytoEX