Ryan Foster
Ryan Foster
Just to keep track of it, adding Qt Designer (qttools) adds 3m34s to the download+configure+build+install step on the Windows x64 RelWithDebInfo build and 4m00s for macOS.
I haven't tested this, but it looks okay. As long as we're aware that autoconfig tests that produce dropped frames will _never_ be flagged again, then I'm fine with this....
While the analyzer as run via OBS Bot does have Hardware Check, the analyzer itself does not. In practice, I'm sure that the analyzer gets more use via OBS Bot...
> An 8th gen laptop i3 (lets say 8121U, quite modest) beats out a 2500k syntethic compute, so I don't really agree with that sentiment that it does not meet...
> > > Two things: > > 1. Could you also add the command the help text? > > 2. You could set a default value of "0" for slowmode,...
Well, it seems we should definitely either clamp `seconds` at 21600 or warn if the value is invalid. Invalid values cause exceptions. Preference?
> > > As a note (because flake8 is going to complain about this), there should be a space between the assignment operator in the parameters, e.g. `int = 0`....
> > > Not many, ideally just respond with an error if anything fails. I can either clamp: ``` # Clamp to the min value of 0 seconds (disabled, no...
> > > Oh yeah, also use `'` for strings rather than `"` to stay in line with the rest of the code. Done.
In its current form, this clamps negative int parameters to 0, and clamps anything higher than 21600 to 21600. If a user specifies a non-integer to the command, it will...