loganalyzer icon indicating copy to clipboard operation
loganalyzer copied to clipboard

network: Ignore autoconfig when checking for dropped frames

Open Penwy opened this issue 1 year ago • 1 comments

Description

When scanning the log fro dropped frames, this ignores any reported by the autoconfig wizard's test stream.

Alongside this, it introduces a new util function, searchExclude, that allows searching lines for a term while excluding others. It was added as a separate function because I felt other parts of the analyzer or future additions to it could benefit from it for clarity and simplicity. If that is deemed unnecessary or better done in a separate PR, it can obviously be changed easily.

Motivation and Context

The autoconfig wizard will always report dropped frames as part of it's normal behaviour, without it being indicative of any actual network issues. As such reporting those in the analyzer can mistakenly lead users to think they have a network issue when they do not.

How Has This Been Tested?

Tested by manually feeding lines to the function. Example log can be found here. It should not report any dropped frames, as the dropped frames in it are only from the autoconfig.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

Penwy avatar Apr 30 '24 06:04 Penwy

I haven't tested this, but it looks okay. As long as we're aware that autoconfig tests that produce dropped frames will never be flagged again, then I'm fine with this. cc @Fenrirthviti for opinion on that.

RytoEX avatar May 02 '24 22:05 RytoEX