Ryan

> Only one minor suggestion, otherwise everything looks good to me! I think this is a really useful feature. > > I merged in `rolling` locally (no conflicts, as you...

If you try to use the on_mouse_move on a variable that doesn't exist, that can cause it to crash.

I tested this in SITL a while back using some of the SIM* params to muck with the GPS health of GPS 1 and 2 and could not get the...

I have made a release here: https://github.com/ArduPilot/Micro-XRCE-DDS-Gen/releases/tag/v4.5.0 We should be able to use this binary in the setup scripts and thus no changes will be needed to the build server.

Nice find. Would you be interested to issue a PR to fix it?

Can you supply a minimum reproducible example to demonstrate the problem? CI is passing the build, so it's not a use case that's being tested.

Thanks. I've pushed to a branch to reproduce this issue. https://github.com/Ryanf55/grid_map/tree/382-bug Here's the problem I see. ``` ryan@B650-970:~/Dev/ros2_ws/src/grid_map$ colcon build --packages-up-to issue382 [0.185s] WARNING:colcon.colcon_core.package_selection:Some selected packages are already built in...

I tried applying patch faa4ae0c4eea364d824ccecb6e9f7a2ac0293ff4, but found that applying these definitions to the target is more complicated than initially proposed by a public target property because this file is exported....

After some time, the changes in NAV2 are available in binaries. This builds now.

Just updated the above comment. I believe the LOS calculation will return the points closer B first if the line goes from right to left because of the way bresenham...