Ryan

icon company Aerovironment Inc. icon location Boulder,CO,USA icon location ROS2, Dev Team @ ArduPilot, IoT

Results 632 comments of Ryan

Github CI on rolling/iron missing tests which causes build farm failures

This is now fixed, binaries just took a while to update.

Fix LoadFromBag assumptions causing C++ exceptions during serialization

> Hello, the fix looks good, I'm sending a minimalistic bag file which contains an empty grid map + chatter topic (unfortunately I cannot post the actual bag where I...

Fix LoadFromBag assumptions causing C++ exceptions during serialization

I've fixed the tests. They pass locally for me, but not in CI. I don't have time to chase it down right now, but as soon as CI is green,...

Fix LoadFromBag assumptions causing C++ exceptions during serialization

@Mergifyio backport jazzy

Fix LoadFromBag assumptions causing C++ exceptions during serialization

@Mergifyio backport iron

Fix LoadFromBag assumptions causing C++ exceptions during serialization

@Mergifyio backport humble

Potential vulnerability: topic and service names from ROS parameters

Hey there, ROS 2 has two methods that invalidate this. 1) Use SROS2 to secure the topics: https://github.com/ros2/sros2 2) Use ROS_LOCALHOST_ONLY if you don't have communications between boxes https://discourse.ros.org/t/unconfigured-dds-considered-harmful-to-networks/25689 Anyone...

Consider updating to ament_export_targets (Modern CMake)

I ran into a blocker, sorry. Issue linked above. The decision to use `BT::` as the exported namespace for conan builds is not supported yet in `ament_export_targets`. `ament_export_targets` hard codes...

Consider updating to ament_export_targets (Modern CMake)

I will test for this scenaio, and probably can add a CI check for it. It should be fixed.

Consider updating to ament_export_targets (Modern CMake)

> @Ryanf55 if we can fix this the next week, it would be ideal, I want to release 4.6 Yes. It merged to rolling last week, but CI failed on...