Rot127
Rot127
> What does the rizin "guess" mode currently do? The search `/z` comand and the `ps` command have different "guess string encoding" functions. `ps` simply checks if it can decode...
@imbillow Is it fine for you if we mark this PR as "Draft"? I get confused in my notifications.
I could not reproduce the segfault with Python 3.13. Only with Python 3.12. I am not sure if we should merge this without this segfault being fixed. Probably not. We...
Yeah, these clean up tasks have to be done before the Beta as well.
By any means necessary. The new graph should hash its nodes and edges. And document how exactly it identifies the nodes. Currently, it compares only pointers of nodes to determine...
Check `RzGraphNode`. It has an index `idx` (I think into the node list) and the `data`. The `idx` is the only unique identifier for the node. It can't have a...
This problem particulary is very annoying. Because the graph easily gets "duplicate nodes" added. Because when adding a node, it doesn't check the data of the other nodes. But checks...
I think it would be good to assign a `hash()` function when the graph is created. So `graph_add_node` takes the node data, passes it to `hash()` and gets the key...
Also we should make the printing of a graph (in different graph formats, dot, GML etc.) independent of `RzCore`. Currently `rz_core_graph_print_graph()` needs the core. Which doesn't make sense. Also, https://github.com/rizinorg/rizin/pull/4753#discussion_r1864303893...
One feature more I'd like to see. It would be nice if the graph can be initialized with a certain capacity of notes. Let's assume we know in advance the...