capstone icon indicating copy to clipboard operation
capstone copied to clipboard

Update Auto-Sync to Python 3.13 and tree-sitter-py 24.0

Open Rot127 opened this issue 7 months ago • 3 comments

Your checklist for this pull request

  • [ ] I've documented or updated the documentation of every API function and struct this PR changes.
  • [ ] I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

  • Updates the API from tree-sitter-py to 24.0

Waiting for comment on https://github.com/tree-sitter/py-tree-sitter/issues/350

Test plan

All green

Closing issues

closes https://github.com/capstone-engine/capstone/issues/2459

Rot127 avatar May 20 '25 12:05 Rot127

I could not reproduce the segfault with Python 3.13. Only with Python 3.12. I am not sure if we should merge this without this segfault being fixed. Probably not. We would need to fix the version to 3.13 then.

But the code is ready for review.

Rot127 avatar Jun 10 '25 12:06 Rot127

I could not reproduce the segfault with Python 3.13. Only with Python 3.12. I am not sure if we should merge this without this segfault being fixed. Probably not. We would need to fix the version to 3.13 then.

But the code is ready for review.

How can I reproduce the segfault? I can investigate this.

jiegec avatar Jun 15 '25 02:06 jiegec

I could not reproduce the segfault with Python 3.13. Only with Python 3.12. I am not sure if we should merge this without this segfault being fixed. Probably not. We would need to fix the version to 3.13 then. But the code is ready for review.

How can I reproduce the segfault? I can investigate this.

See https://github.com/tree-sitter/py-tree-sitter/issues/350#issuecomment-2949876596

notxvilka avatar Jun 15 '25 09:06 notxvilka