Rot127

Results 554 comments of Rot127

Going to move https://github.com/rizinorg/rizin/pull/3837/commits/458fc61836e82da8ceee5de36c58dca6d38bd200 into a separated PR. But first wanted to see if it finally works.

So besides https://github.com/rizinorg/rizin/issues/4121 everything runs fine now. I have no idea what the problem with it is unfortunately. But it isn't related to the RzIL stuff. The appveyor fails due...

Please let me run all `rz-tracetest` tests after https://github.com/rizinorg/rizin/pull/4373. Just to be sure.

Ok, all good now: ``` ./run-test-sets.sh -i -t essentials,float test_vspliceb [PASS] test_vpmpyh [PASS] test_vminh [PASS] test_vmaxh [PASS] test_vlsrw [PASS] test_vcmpw [PASS] test_vcmpb [PASS] test_vavgw [PASS] test_round [PASS] test_reorder [PASS] test_packet...

As an indicator where problems can occur: The list with usages of zero initialized pointer as keys hash tables: ```bash > grep -rnIE "ht_p[up]_new0\(" librz/ librz/util/set.c:9: return ht_pp_new0(); librz/util/lib.c:33: lib->opened_dirs...

`HtPx` is supposed to be used with strings as keys. As @wargio [suggested](https://github.com/rizinorg/rizin/pull/4260#discussion_r1494108929), the proper fix would be in this case to introduce `HtSx` (`S` for strings). While `HtPx` should...

Ah nice. That is why it worked :D As long as we don't use `SetP` until it's refactored, it's fine (with the one exception of yours of course).

@wargio Interestingly not, I had a case when it used the buckets. Push the test for it in a second. Which just strengthens your point to make the functioning of...

```c bool test_htuu_uses_buckets(void) { HtUU *ht = ht_uu_new0(); ht_uu_insert(ht, 0, 1); ht_uu_insert(ht, 1, 1); ht_uu_insert(ht, 2, 1); ht_uu_insert(ht, 3, 1); printf("\nht->count = %d\n", ht->count); ht_uu_insert(ht, 10000000, 1); printf("ht->count = %d\n",...