Rot127
Rot127
Thanks for the detailed report. All of these problems (incorrect implicit registers, incorrect operands, operand access information and incorrect instruction groups) are likely all solved by https://github.com/capstone-engine/capstone/pull/2013. https://github.com/capstone-engine/capstone/pull/2013 will also...
These are the results for the branch instructions you gave me (registers are still broken, please ignore this part): ``` 0 41 82 00 3c bt eq, 0x3c ID: 1681...
> bdnz has cr0 mentioned Right. There is an `if` clause missing. Thanks. I'll implement the implicit registers later. The merge of the PR is planned around mid-end of July....
Mappings are fixed in https://github.com/capstone-engine/capstone/pull/2333. But it is not worth to fix the first point. This is done in the `next` branch. So I mark this as `wontfix` and close...
Some tests: | commit | tests (no asan) | |--------|-----------------| | https://github.com/rizinorg/rizin/pull/4260/commits/fdd5aaa1c3a0f882a6121bd94ec24748809d2c70 | green | | https://github.com/rizinorg/rizin/pull/4260/commits/901faeb80526f676bd5c90e44b972c2338e43e41 | green | At least the one occasion `SetP` is used, doesn't seem...
Indeed.
The good thing is though, that the push and pops where always contained in a single function. So if we have RzCons properly implemented with mutexes or even can synchronize...
Just discovered that the PCRE2 JIT compiler apparently can't run on iOS (https://github.com/PCRE2Project/pcre2/issues/212). If you run into errors, just disable it [here](https://github.com/rizinorg/rizin/blob/c2b9208fc2779eb2dce2d3c104f247c6306aa6cc/subprojects/packagefiles/pcre2/meson.build#L62-L65).
@valdaarhun Sorry, I missed the mention above from @XVilka. It's fine, if for now it can only check for `armv8` or the M-profile. Although, please ensure it is easily extendible....
How about we change this PR to re-implement the sets properly? `SetU` works fine, if it uses `HtUU` (not in this implementation thoug, push some commits later). And we can...