Rot127
Rot127
Also I couldn't find any unit tests specifically for the hash tables. Which should be definitely added.
@ret2libc Any opinion on the `foreach` macro construction? I found the implemented `foreach` loop via callbacks really unpractical. But It looks a little wonky. But if you in general approve...
Then let me extend the PR to include more foreach macros: So the todo list would be: - [ ] Use @pelijah suggested changes - Add foreach for: - [...
Implemented by https://github.com/rizinorg/rizin/pull/4500
You need to open it with `rizin -a arm ls` if you are on a `x86` machine. Its this weird `macho` thing that it contains `x86` and `arm` assembly in...
This seems to miss some. E.g. the [internal plugin state](https://github.com/rizinorg/rizin/blob/0440ab4372ce0c938be7a1c4975b4d301c27d024/librz/asm/arch/hexagon/hexagon_arch.c#L254) for Hexagon.
Open this for the first round of review now. There are still the `rz-test` cases missing. Due to inner working of the RzIL generation it is not really possible to...
In order that the tests succeed we need https://github.com/rizinorg/rizin-testbins/pull/127 merged though. Before that maybe look at https://github.com/rizinorg/rizin/pull/3837/files#diff-a1583f59ca1cc7b3c25cde35c24fade6df510112bcf21174d5d2995a5baa14e2
@thestr4ng3r To your notice: https://github.com/rizinorg/rizin/pull/3837/commits/722e5c0a624136b7a07cd4d2ee42e54d3c5fc0c6
If this is green, could you guys take a look at it again.