rizin icon indicating copy to clipboard operation
rizin copied to clipboard

Proof HtPP anomaly

Open Rot127 opened this issue 1 year ago • 1 comments

Your checklist for this pull request

  • [ ] I've read the guidelines for contributing to this repository
  • [ ] I made sure to follow the project's coding style
  • [ ] I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • [ ] I've added tests that prove my fix is effective or that my feature works (if possible)
  • [ ] I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

...

Rot127 avatar Feb 18 '24 09:02 Rot127

Some tests:

commit tests (no asan)
https://github.com/rizinorg/rizin/pull/4260/commits/fdd5aaa1c3a0f882a6121bd94ec24748809d2c70 green
https://github.com/rizinorg/rizin/pull/4260/commits/901faeb80526f676bd5c90e44b972c2338e43e41 green

At least the one occasion SetP is used, doesn't seem to suffer from it.

Rot127 avatar Feb 19 '24 05:02 Rot127

@Rot127 I suppose this one isn't needed anymore?

XVilka avatar Apr 19 '24 11:04 XVilka

Indeed.

Rot127 avatar Apr 19 '24 12:04 Rot127