Olaoluwa Osuntokun
Olaoluwa Osuntokun
I think before broadcast, we can call into `CheckMempoolAccept`, then only broadcast if that returns that it's likely to be accepted. Here's an example in `lnd`: https://github.com/lightningnetwork/lnd/blob/6bf895aeb929fb64265bfb226f796392921d8d3a/lnwallet/btcwallet/btcwallet.go#L1928-L1957
Pushed up a commit to consolidate a lot of the duplication between the ignore and burn trees.
Pushed up a commit to solve the collision issues. We add a new interface for `LeafKey`, then make a new concrete `BaseLeafKey` implementation. This way any methods that needs the...
Pushed up latest iteration. This is dependent on the ignore tree PR.
> TODO for myself: add group key to channel funding blob, see To be done in this PR?
Enabling positive inbound fees is off by default, it's also marked that it's a config field that really shouldn't be used at all outside of testing: https://github.com/lightningnetwork/lnd/blob/master/sample-lnd.conf#L441-L446
> Why do you need to allow enabling it on mainnet? The code could allow enabling this only on regtest and testnet to be safer? Here's what the help text...
/gemini review
Just added it, will also copy over the similar config we have for lnd.
> This is directly encoded inside the ping message instead of using a TLV? That doesn't seem very future-proof, it doesn't support padding with random bytes to create ping messages...