Olaoluwa Osuntokun

Results 793 comments of Olaoluwa Osuntokun

Added a final set of commits to add the new channel type to the relevant commitment type test matrices in the itests.

Tacked on two additional commits to add the nonce map to revoke and ack.

Pushed a commit to only set the new nonce map field based on the "final" feature bit.

This is dependent on https://github.com/lightningnetwork/lnd/pull/9639

In order to add that field, you'd need to implement descriptors first: https://github.com/btcsuite/btcd/issues/2137. We'd accept a PR doing so.

i think only the first 3 should be moved to another section. The others in that section contain errors that the second-to-last node can/should send, but the final node shouldn't....

Tacked on a commit to revise the way to handling the parsing of the various sigs. I still find the spec somewhat confusing (eg: why would I ever send both...

> I'm halfway there, meanwhile I just realized there are some commits in the base branch, i think we should rebase on master? So it's built on a few branches...