Olaoluwa Osuntokun

Results 793 comments of Olaoluwa Osuntokun

Re the version: we tyupically try to track the last two versions (so Go 1.19 and 1.20 rn) so I think no issue bumping it. We'll also likely have more...

Glanced at the draft patch above from @nikicat, looks like a good start, but is insufficient as testnet4 has entirely consensus rules that don't yet exist on mainnet: * https://github.com/bitcoin/bips/blob/a35650e14e5e3afce269efa0926233c30871b140/bip-0094.mediawiki#block-storm-fix...

> Might want to also allow setting these channels as non-private as they can then be used for routing payments as well. As these are Taproot channels, they can't be...

The `FixedPointFromUint64` function will do the scaling _for you_. You provide the base value, and it does the multiplication needed to scale it up. The base value is the amount...

Seems low prio. Unclear if anyone building actually needs something like this or not. If you want to just add the function in a PR to the package, you're free...

> I think maybe the proper amount of coins isn't be distributed to the nodes before trying to open channels or maybe it is just not waiting for transactions to...

> So you are saying that it is not adjustable by design? No, see this fragment: > If you're increasing the amount of asset needed to fund a channel, then...

Makes sense, when we get the RFQ response/accept back, we should use that to set a custom expiry on the invoice.

FWIW, there really isn't any sort of JSON-RPC standard that exists amongst Bitcoin nodes (no BIP, etc). Long ago, we decided to no longer follow all the induvidual changes that...

What does your local `go.mod` look like?