Olaoluwa Osuntokun

Results 792 comments of Olaoluwa Osuntokun

> lgtm if sign_psbt here (https://github.com/lightningnetwork/lnd/runs/7798107595?check_suite_focus=true) is an unrelated flake Investigated offline, appears to be a flake unique to the `bitcoind` backend. Landing this then will make an issue to...

> quick question while testing this: I see the aliases we assign are incremented by a counter. Is this not a bit of a leak? The alternative would be to...

This just needs release notes then it can land.

> I looked into using the paymentsIndexBucket to do a binary search, but after digging around the code in channeldb, I don't think I can confidently say whether payment indices...

> The ImportTaprootScript was built for importing a p2tr address with a script tree, I don't think that supports BIP86 just yet. Cool, I thought maybe it would be possible...

We started to understand warning messages in [this PR](https://github.com/lightningnetwork/lnd/pull/6546) which is unreleased (only exists in master). There should be a [different log for nodes on master](https://github.com/lightningnetwork/lnd/pull/6546/files#diff-9926ec0b86d09ad93deb44807ccee9a52ed42535007f96ae497478c07b76843aR1999-R2005), and nodes on 0.15...

@Crypt-iQ where is it converting there before it passes the message? It converts to check what channel is being targeted, but `nextMsg` (which should still be `lnwire.Warning` is what's passed...

@TheBlueMatt The reason y'all send the warning is also pretty interesting ("Unreadable/bogus gossip message"), might deserve another issue in the tracker. Is is that the gossip message is invalid from...

Closing since this is an issue w/ selected peers. If you use `connect` instead of `addpeer`, then you'll also seek out more peers over time.

> When trying to send an amount larger than the balance of any single channel but smaller than the total balance, it's better to send a shard with the amount...