Olaoluwa Osuntokun comments

Results 792 comments of


                                            Olaoluwa Osuntokun

Try to send the largest amount from a single channel.

I guess the argument is that this may end up with less splits total in the end?

Try to send the largest amount from a single channel.

!lightninglabs-deploy mute

chainntnfs: leverage batched JSON-RPC requests to speed up spend/conf rescans

This PR in `btcwallet` may resolve this issue: https://github.com/btcsuite/btcwallet/pull/807

Sending incorrect onion error for "peer offline"

Our behavior is based on this fragment: > if the receiving peer specified by the onion is NOT known: > return an unknown_next_peer error. So IMO the wording can be...

lnd updatechanpolicy has confusing --help

You can't have a value of 0 for the CLTV delta. If you did, then you'd be exposed to losing funds on each HTLC you forward, as a race condition...

lnd updatechanpolicy has confusing --help

That's the default value for the _cli_, not `lnd` default values. You can see the default values for those fields at `lnd -h`: ``` --bitcoin.minhtlc= The smallest HTLC we are...

lnd updatechanpolicy has confusing --help

You don't need to set a value, if you aren't actually modifying it.

lnwallet/btcwallet: use CheckTransactionStandard to validate txns before broadcast

Thanks to @ellemouton for making the change to the btcd's `mempool` package to export the func used here.

lnwallet/btcwallet: use CheckTransactionStandard to validate txns before broadcast

This is a very simple approach that just ensures we won't broadcast these transactions. Ideally we should add this check before this step even, in areas like the funding manager...

lnwallet/btcwallet: use CheckTransactionStandard to validate txns before broadcast

> lready handles removing the failed tx from TxStore, what's the effect of adding CheckTransactionStandard from the caller's view? That's a good question: AFAICT, something is happening where even though...