lnd icon indicating copy to clipboard operation
lnd copied to clipboard

multi: use taproot errwhere applicable for change/delivery/tower addresses

Open Roasbeef opened this issue 3 years ago • 1 comments

With this PR, we'll start to use taproot addresses by default when: sweeping all funds from the wallet, funding channels, and sending blobs to watch towers.

Fixes https://github.com/lightningnetwork/lnd/issues/6666

Roasbeef avatar Aug 09 '22 02:08 Roasbeef

@guggero I fixed that failing tower test by using a taproot address in the test itself. It was using a p2pkh address before.

Roasbeef avatar Aug 09 '22 02:08 Roasbeef

Alrighty, I pushed up a set of fresh commits that should cover all the outstanding cases. I broke up the commits to make things a bit easier to follow. There were a still areas where we also assumed the expected dust output that should be fixed.

Roasbeef avatar Aug 11 '22 01:08 Roasbeef

lgtm if sign_psbt here (https://github.com/lightningnetwork/lnd/runs/7798107595?check_suite_focus=true) is an unrelated flake

Investigated offline, appears to be a flake unique to the bitcoind backend. Landing this then will make an issue to investigate. Seems like the test isn't waiting long enough for the wallet to fully recognize the coins?

Roasbeef avatar Aug 12 '22 21:08 Roasbeef