Reuben Gardos Reid comments

Results 32 comments of


                                            Reuben Gardos Reid

Set IOContext for redirected stdout/stderr

I've created some end-to-end style tests to cover the cases you mentioned, @fonsp. What's the best way to incorporate these? Just open a new PR?

Set IOContext for redirected stdout/stderr

Looks like just one of the Throttled tests is failing. Should be all set otherwise!

Set IOContext for redirected stdout/stderr

Sure thing. I won't have time until a couple of weeks from now, but I'd be happy to then.

ChatModerator bypasses link when it contains oc.tc but it's vulnerable

Yes it's a bug, but I don't think it matters because when adding the oc.tc as a subdomain it breaks the link. It still should be fixed though, just pointing...

Error in Example Code from Herb.jl Installation Guide – `execute_on_input` Fails with `ContextSensitiveGrammar`

Thanks for the report 👍 We've slowly been moving all documentation to be tested in CI to catch things like this, but as you can see, we haven't caught up...

Error in Example Code from Herb.jl Installation Guide – `execute_on_input` Fails with `ContextSensitiveGrammar`

Fixed in #126

Implement `TYPEDSIGNATURENORETURN`

Certainly! I also wanted to add another test or two before review. Thanks for the speedy reply!

Implement `TYPEDSIGNATURENORETURN`

Pesky, pesky formatting. Should be good to go now @MichaelHatherly.

Implement `TYPEDSIGNATURENORETURN`

Also, not sure what your release workflow is—should I include a (patch) version bump in this PR?

Implement `TYPEDSIGNATURENORETURN`

Oops, something odd is happening, looks like the tests are not extensive enough yet. Give me a moment here.