Reuben Gardos Reid

Results 32 comments of Reuben Gardos Reid

That should also fill in the missing releases on the documentation as they correspond to tags IIRC. Thanks for taking the time to update this! Much appreciated.

Nice! Can you open a PR from the `documentation` branch to `master` so that someone can review?

Note: the code used in the guide is outdated (https://herb-ai.github.io/Herb.jl/dev/install/#3.-Run-some-example-code). `SymbolTable` should be `grammar2symboltable`.

Check whether these changes are included in Pam's branch

@pwochner started work in https://github.com/Herb-AI/Herb.jl/tree/documentation-core-concepts

Got it. Seems like an easy thing to support, right? I could make a quick PR for it if you like.

The package is relying on and implementing `TermInterface` again as of 2.0 (https://github.com/JuliaSymbolics/SymbolicUtils.jl/commit/4b3ae15c6a8c1c8a007f4842ea90b5cf845bbe6f). Looks like this is no longer relevant, right?

> But now you only have to implement `TermInterface.head` and optionally `TermInterface.metadata`. Is that generally true? It seems surprising to me that you don't also need `TermInterface.children`, but I'm not...

Just ran into the same question and came across this solution for supporting both `Requires` and `Pkg` extensions: https://github.com/SciML/DiffEqBase.jl/commit/c2de920a88a39814ac368f703c40fbc282a9c078#diff-de4c4ba0a280ecb9ba500e64be262686e3f8efdd99b60152eec26cc1263afbb1 in case you'd like to use extensions without upping the lower...

I see the plan is to only support >1.9 as of #425, so maybe this isn't useful in the end