Viet Tran Ba
Viet Tran Ba
**Please describe your :rocket: feature request.** As a user with access to custom data about optical parameters, I would like to define a tissue from these optical parameters instead of...
**Please check the following before creating the pull request (PR):** - [x] Did you run automatic tests? - [ ] Did you run manual tests? - [x] Is the code...
**Please describe your :rocket: feature request.** As a developer who is unfamiliar with the effects of lighting on simulations, I want to define a global light that evenly illuminates the...
Currently, while the files in this module are already well-documented, the code lacks docstrings for some methods and type hints for some parameters. Adding the missing documentation will further improve...
**Describe the bug** Commonly, the background of the tissue volume is defined as: background_dictionary[Tags.MOLECULE_COMPOSITION] = TISSUE_LIBRARY.constant(1e-4, 1e-4, 0.9) Because this function uses CONSTANT_ABSORBER_ARBITRARY, the background tissue is defined for only...
**Please check the following before creating the pull request (PR):** - [x] Did you run automatic tests? - [x] Did you run manual tests? - [x] Is the code provided...
**Please describe your :rocket: feature request.** Add the -b / --reflect flag to the MCX simulation without breaking any existing reflectance behavior (https://mcx.space/wiki/index.cgi?Doc/mcx_help). **Describe the solution you'd like** Update the...
Classes with abstract methods should be abstract themselves. Therefore, ensure that every abstract class inherits from abc.ABC so that users can immediately tell that the class is an abstract class.
**Please describe your :rocket: feature request.** As a Simpa user mainly interested in the optical simulations to analyze the reflectance spectra from the simulated tissue, I would like to get...
**Please describe your _refactor_.** Due to the test TestCoreAssumptions.test_volume_fractions_sum_to_less_or_equal_one(), all function parameters have to define a default value. This does not always make sense however for the method constant and...