simpa icon indicating copy to clipboard operation
simpa copied to clipboard

Add MCX simulation reflection flag -b

Open RecurvedBow opened this issue 1 year ago • 5 comments

Please describe your :rocket: feature request. Add the -b / --reflect flag to the MCX simulation without breaking any existing reflectance behavior (https://mcx.space/wiki/index.cgi?Doc/mcx_help).

Describe the solution you'd like Update the MCXAdapter to accept a boolean flag whether the photons should be reflected or transmitted at the simulation borders.

RecurvedBow avatar Jul 02 '24 14:07 RecurvedBow

Will only apply reflection on the volume faces along the x-axis and z-axis

RecurvedBow avatar Jul 03 '24 07:07 RecurvedBow

Since there are multiple possible behaviors, will define an enum instead of a boolean flag instead. Will include: default, fresnel reflection, mirror reflection, cyclic

RecurvedBow avatar Jul 03 '24 08:07 RecurvedBow

This issue is related to #286 and we'll wait until that one is resolved :)

kdreher avatar Jul 03 '24 08:07 kdreher

This could also be resolved by #311 since user-defined flags could be passed and would overwrite the default ones.

leoyala avatar Jul 03 '24 12:07 leoyala

I have found out that the command flags for capturing reflectance are set incorrectly: we do not need --saveref; and there is actually a bug with saving photon direction and position on exit. I will address the first case in this issue, and add the second as a bug issue

RecurvedBow avatar Jul 05 '24 11:07 RecurvedBow