Reto

icon location Switzerland icon location Usually working on cloud native stuff

Results 185 comments of Reto

Test for internal TLS certificate rotation

/lgtm /approve

Test for internal TLS certificate rotation

> @ReToCode As you mentioned https://github.com/knative/serving/pull/15217#discussion_r1607753785, we should not be deleting the old cert from the trust-bundle ConfigMap because the test is quick and the certificates might not be rotated...

Test for internal TLS certificate rotation

/lgtm /approve

Test for internal TLS certificate rotation

IMHO, we can skip certmanager-integration-tests_serving_main, as per https://github.com/knative/serving/pull/15261

Using the `addresses` array in Knative Serving

I'm not sure I understand what is asked here. In Serving status you can already find the public and the cluster local domain: ``` - apiVersion: serving.knative.dev/v1 kind: Service spec:...

[WIP] Add affinity-rules feature to configmap config-deployment

LGTM

Multiple Reference Grant for specific service in the same namespace didn't work as expected.

Same problem discovered here: https://github.com/knative-extensions/net-gateway-api/pull/437, both configuration work as long as they are not applied at the same time: - error in gateway: https://gist.github.com/ReToCode/63ecd5af04c1a70fe64009da4a6b578d#file-gateways-yaml-L137 - reference grants are there: https://gist.github.com/ReToCode/63ecd5af04c1a70fe64009da4a6b578d#file-refgrants-yaml-L27...

fix: fixed the pinned dependencies issue

/hold see https://github.com/knative/serving/issues/15474#issuecomment-2355393448

net-istio-controller crashes with error "Failed to start informers" - "failed to wait for cache at index 8 to sync"

How many (and large) secrets do you have in your cluster? Maybe try https://github.com/knative-extensions/net-istio/pull/920 (check the release notes in that PR).

rename user container to main container

Also before doing the actual rename of constants here, I'd start with checking the first points in https://github.com/knative/serving/issues/15007. Can ALL the occurences (including the actual values) in serving, pkg and...