serving
serving copied to clipboard
rename user container to main container
Fixes #15007
Proposed Changes
*Renamed all UserContainer occurences to MainContainer in pkg package
*
*
Release Note
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: EraKin575 Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Welcome @EraKin575! It looks like this is your first PR to knative/serving 🎉
Hi @EraKin575. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/hold we shouldn't be duplciating work
https://github.com/knative/serving/issues/15007#issuecomment-2173124094
@dprotaso I think we can remove this from hold now
/ok-to-test
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.59%. Comparing base (
af2c899) to head (5b1179f).
:exclamation: Current head 5b1179f differs from pull request most recent head 3fec7ce
Please upload reports for the commit 3fec7ce to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## main #15330 +/- ##
==========================================
- Coverage 84.61% 84.59% -0.02%
==========================================
Files 219 219
Lines 13584 13584
==========================================
- Hits 11494 11492 -2
- Misses 1724 1726 +2
Partials 366 366
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Also before doing the actual rename of constants here, I'd start with checking the first points in https://github.com/knative/serving/issues/15007. Can ALL the occurences (including the actual values) in serving, pkg and docs be changed without breaking any public API? Only if the answer is true, we should actually rename stuff.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.