serving icon indicating copy to clipboard operation
serving copied to clipboard

rename user container to main container

Open EraKin575 opened this issue 1 year ago • 9 comments

Fixes #15007

Proposed Changes

*Renamed all UserContainer occurences to MainContainer in pkg package * *

Release Note


EraKin575 avatar Jun 17 '24 02:06 EraKin575

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EraKin575 Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Jun 17 '24 02:06 knative-prow[bot]

Welcome @EraKin575! It looks like this is your first PR to knative/serving 🎉

knative-prow[bot] avatar Jun 17 '24 02:06 knative-prow[bot]

Hi @EraKin575. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Jun 17 '24 02:06 knative-prow[bot]

/hold we shouldn't be duplciating work

https://github.com/knative/serving/issues/15007#issuecomment-2173124094

dprotaso avatar Jun 25 '24 13:06 dprotaso

@dprotaso I think we can remove this from hold now

EraKin575 avatar Jun 27 '24 17:06 EraKin575

/ok-to-test

dprotaso avatar Jun 27 '24 21:06 dprotaso

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.59%. Comparing base (af2c899) to head (5b1179f).

:exclamation: Current head 5b1179f differs from pull request most recent head 3fec7ce

Please upload reports for the commit 3fec7ce to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15330      +/-   ##
==========================================
- Coverage   84.61%   84.59%   -0.02%     
==========================================
  Files         219      219              
  Lines       13584    13584              
==========================================
- Hits        11494    11492       -2     
- Misses       1724     1726       +2     
  Partials      366      366              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 27 '24 21:06 codecov[bot]

Also before doing the actual rename of constants here, I'd start with checking the first points in https://github.com/knative/serving/issues/15007. Can ALL the occurences (including the actual values) in serving, pkg and docs be changed without breaking any public API? Only if the answer is true, we should actually rename stuff.

ReToCode avatar Jul 01 '24 11:07 ReToCode

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow-robot avatar Aug 16 '24 15:08 knative-prow-robot

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Nov 15 '24 01:11 github-actions[bot]