serving icon indicating copy to clipboard operation
serving copied to clipboard

[WIP] Add affinity-rules feature to configmap config-deployment

Open izabelacg opened this issue 1 year ago • 2 comments

Proposed Changes

Release Note


izabelacg avatar May 24 '24 19:05 izabelacg

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.79%. Comparing base (ab5c1a0) to head (6c9252f). Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15250      +/-   ##
==========================================
+ Coverage   84.73%   84.79%   +0.06%     
==========================================
  Files         218      218              
  Lines       13479    13504      +25     
==========================================
+ Hits        11421    11451      +30     
+ Misses       1689     1687       -2     
+ Partials      369      366       -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 27 '24 17:05 codecov[bot]

/retest

izabelacg avatar May 27 '24 20:05 izabelacg

@dprotaso can you take a look? Is there any other testing we may want to run before I take the WIP off from the MR?

izabelacg avatar May 27 '24 20:05 izabelacg

/retest

izabelacg avatar May 27 '24 20:05 izabelacg

/retest all

izabelacg avatar May 29 '24 17:05 izabelacg

@izabelacg: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

  • /test build-tests
  • /test contour-latest
  • /test contour-tls
  • /test gateway-api-latest
  • /test istio-latest-no-mesh
  • /test istio-latest-no-mesh-tls
  • /test kourier-stable
  • /test kourier-stable-tls
  • /test unit-tests
  • /test upgrade-tests

The following commands are available to trigger optional jobs:

  • /test gateway-api-latest-and-contour
  • /test https
  • /test istio-latest-mesh
  • /test istio-latest-mesh-short
  • /test istio-latest-mesh-tls
  • /test performance-tests

Use /test all to run the following jobs that were automatically triggered:

  • build-tests_serving_main
  • istio-latest-no-mesh-tls_serving_main
  • istio-latest-no-mesh_serving_main
  • unit-tests_serving_main
  • upgrade-tests_serving_main

In response to this:

/retest all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar May 29 '24 17:05 knative-prow[bot]

/test all

izabelacg avatar May 29 '24 17:05 izabelacg

/retest

izabelacg avatar May 29 '24 17:05 izabelacg

@izabelacg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
certmanager-integration-tests_serving_main 92f0ab5a3b741f5e39a7aec8f57129902c37a358 link true /test certmanager-integration-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

knative-prow[bot] avatar Jun 03 '24 15:06 knative-prow[bot]

/retest

izabelacg avatar Jun 03 '24 18:06 izabelacg

cc @skonto @ReToCode for input

dprotaso avatar Jun 04 '24 18:06 dprotaso

LGTM

ReToCode avatar Jun 06 '24 05:06 ReToCode

/lgtm /approve

dprotaso avatar Jun 06 '24 13:06 dprotaso

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Jun 06 '24 13:06 knative-prow[bot]