Abhishek Maheshwari comments

Results 9 comments of


                                            Abhishek Maheshwari

trafficstars

chore: converted strings displayed to the user into string resource objects.

@shiv07tiwari @devansh-299 Please review this PR :)

fix : converted all inner class based alert dialog box to our global class based dialog box

@devansh-299 PTAL :)

Delete Bank Button is not working in Bank Account Details

Is this issue still open?

React 18 Flickering

> Leave `this.clearThreeCanvas()` only in `getSnapshotBeforeUpdate` and remove it from other places This fixed the problem, Does it have any consequences? If not why is someone not creating a PR...

> Leave `this.clearThreeCanvas()` only in `getSnapshotBeforeUpdate` and remove it from other places @Cr1pter I resolved the issue in next.js with this suggestion, You can do these changes in the ChartCanvas.js...

Every user displayed message/text should be a string resource object

@devansh-299 @shiv07tiwari Can I work on this issue?

Every user displayed message/text should be a string resource object

> @ReCodee This is a good issue. In this, I would like to give a suggestion:- > As you said that we should shift to XML files because of the...

fix: Convert inner class of Alert Dialog box to our class DialogBox

@devansh-299 @luckyman20 @Bhavnaharitsa @shiv07tiwari if no one is working on this issue, can I take this up?

fix: Convert inner class of Alert Dialog box to our class DialogBox

@devansh-299 can I work on this issue??