mobile-wallet icon indicating copy to clipboard operation
mobile-wallet copied to clipboard

fix: Convert inner class of Alert Dialog box to our class DialogBox

Open Bhavnaharitsa opened this issue 5 years ago • 9 comments
trafficstars

Summary: Our app still has some alert boxes extracted from the inner class in Android. But, since we have our own global alert box, I think all the alert boxes that was previously built using inner class can be converted.

Bhavnaharitsa avatar Jan 19 '20 15:01 Bhavnaharitsa

Go ahead.

luckyman20 avatar Jan 19 '20 15:01 luckyman20

@luckyman20 @shiv07tiwari It is not possible to convert the code in CardFragment as it does not pass the Travis CI and the error is that the line crosses 100 lines.

Bhavnaharitsa avatar Jan 20 '20 15:01 Bhavnaharitsa

@luckyman20 @shiv07tiwari It is not possible to convert the code in CardFragment as it does not pass the Travis CI and the error is that the line crosses 100 lines.

You can shorten the length by either making variable names shorter or by adding a new line between the line of code.

laxyapahuja avatar Jan 20 '20 17:01 laxyapahuja

@Bhavnaharitsa please paste that code segment here

shiv07tiwari avatar Jan 24 '20 10:01 shiv07tiwari

image

I guess you can observe the code crossing the line..that's where the gradle error shows @shiv07tiwari @luckyman20

Bhavnaharitsa avatar Jan 26 '20 16:01 Bhavnaharitsa

@Bhavnaharitsa you can add a new line after the ',' to make it move to the next line.

laxyapahuja avatar Jan 26 '20 19:01 laxyapahuja

@devansh-299 @luckyman20 @Bhavnaharitsa @shiv07tiwari if no one is working on this issue, can I take this up?

ReCodee avatar Oct 29 '20 07:10 ReCodee

@devansh-299 can I work on this issue??

ReCodee avatar Nov 27 '20 16:11 ReCodee

@devansh-299 can I work on this issue?? Sure go ahead

devansh-299 avatar Nov 27 '20 17:11 devansh-299

Closing as we moved purely on compose.

therajanmaurya avatar Jan 29 '25 20:01 therajanmaurya