mobile-wallet icon indicating copy to clipboard operation
mobile-wallet copied to clipboard

Every user displayed message/text should be a string resource object

Open ReCodee opened this issue 5 years ago • 3 comments
trafficstars

Summary:

We should make a string resource object for every user displayed message/text, so that if in the future we plan to add multi-language functionality, then we can easily provide a multi-language alternative.

For eg:- we have many variables declared inside Constants.java which contain user displayed message/text and could be a hindrance in the future while adding multi-language functionality.

ReCodee avatar Nov 16 '20 11:11 ReCodee

@devansh-299 @shiv07tiwari Can I work on this issue?

ReCodee avatar Nov 16 '20 11:11 ReCodee

@ReCodee This is a good issue. In this, I would like to give a suggestion:- As you said that we should shift to XML files because of the multi-language support. So it's better to add those strings in it that are displayed to the user. All other strings that are being used internally can be kept in Constatnts.java

shiv07tiwari avatar Nov 16 '20 19:11 shiv07tiwari

@ReCodee This is a good issue. In this, I would like to give a suggestion:- As you said that we should shift to XML files because of the multi-language support. So it's better to add those strings in it that are displayed to the user. All other strings that are being used internally can be kept in Constatnts.java

Thanks for the suggestion :), I'll make changes accordingly.

ReCodee avatar Nov 17 '20 09:11 ReCodee

Fixed in compose implementation

therajanmaurya avatar Jan 29 '25 20:01 therajanmaurya