Darshan Sen

Results 54 comments of Darshan Sen

The agenda is empty this time too, let's cancel?

FWIW, https://github.com/nodejs/node/pull/44250 too has been marked with https://github.com/nodejs/TSC/labels/tsc-agenda, so it might make sense to tackle both topics this week because we did TSC meetings in the past with only 2...

@YuriL180821 you would need to scroll up a number of lines to see the error: https://ci.appveyor.com/project/electron-bot/electron-92tg5/builds/43923326#L41348 ```console ../../electron/shell/browser/notifications/win/windows_toast_notification.cc(1291,51): error: comparison of integers of different signs: 'int' and 'ULONG' (aka 'unsigned...

> I believe it will be a build-time flag. Why not a regular cli option?

@twitharshil that one is actually a runtime flag accompanied by a build time flag. `--use-bundled-ca` and `--use-openssl-ca` are the runtime flags. `--openssl-use-def-ca-store` is the build time flag that is used...

There's no way to know if this actually fixes the issue because this PR targets `main` where we use OpenSSL v3. Maybe we could backport https://github.com/nodejs/node/pull/44148 to `v16.x-staging` (that uses...

@aduh95 aren't `mustCall`s for making sure that a callback passed to a function gets called? This one's totally synchronous, that's why I tested this completely based on the change in...

To be clear, the PR that exposed `Module._stat` has already landed and it has been released to v18 and v16, I'm not sure why a test for such a thing...

@GeoffreyBooth > Where's the suggestion for reverting? I posted the comment about reverting in https://github.com/nodejs/node/pull/44713#issuecomment-1287069974 in case we are not comfortable with exposing `Module._stat`. > Even if we eventually revert...

> `util.inherits()` is deprecated and should be avoided to use. It's not deprecated, just legacy which means that it's okay if you use it. You can see the differences in...