test: fix addon tests compilation with OpenSSL 1.1.1

[AdamMajer]

openssl/provider.h header is not part of OpenSSL 1.1.1 so do not include it when building with an older instance.

Fixes: https://github.com/nodejs/node/issues/44722

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46660/

[RaisinTen]

There's no way to know if this actually fixes the issue because this PR targets main where we use OpenSSL v3. Maybe we could backport https://github.com/nodejs/node/pull/44148 to v16.x-staging (that uses OpenSSL v1) first and then apply this patch to verify?

Also, cc @richardlau since this was added in https://github.com/nodejs/node/pull/44148.

[AdamMajer]

@RaisinTen -- it fixes is :wink:

Our default OpenSSL version for openSUSE Tumbleweed is still OpenSSL 1.1.1. This is the reason why this issue came up. The idea is not to break OpenSSL 3.x here while fixing the use-case of external OpenSSL 1.1.1 usage.

https://build.opensuse.org/package/show/devel:languages:nodejs/nodejs18

[richardlau]

There's no way to know if this actually fixes the issue because this PR targets main where we use OpenSSL v3. Maybe we could backport #44148 to v16.x-staging first and then apply this patch to verify?

The CI, even for main, does test that we can build Node.js against a dynamically linked OpenSSL 1.1.1: https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_openssl111_x64/ That didn't catch this in https://github.com/nodejs/node/pull/44148 for some reason.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46675/

[nodejs-github-bot]

Landed in 456591829bf2785c1b02b607338d74f9c481ba96

[juanarbol]

Hey, this is fantastic!

I will bale this as "dont-land-on-v16.x", this depends on https://github.com/nodejs/node/pull/44148, which is not landed in the v16.x release branch.