Ethan Mahintorabi

Results 203 comments of Ethan Mahintorabi

That seems reasonable. It seemed like Anton was suggesting that the instances just got moved to some legal location, which I thought might lead to unreasonably long routes in some...

I'm happy to update the PDK rather than trying to work around it.

IMO this is the wrong fix for the problem. Spdlog stopped providing automated ways to convert enums to ints. OpenROAD should static cast the enums to ints or provide enum...

I uncommented the line to see if things would break, but it looks like it improves the slack on designs like AES. To ``` --------------------------------------------------------------------------- 7.663 data required time -9.087...

@osamahammad21 @maliberty Should we remove the break statement?

If that's the case why is dividing by toApCnt in the lines following this loop? It seems at some point there was some kind of averaging algorithm that is now...

Image is intentionally cut off.

We may want to throw an error on known bad versions of boost or bundling a known good version.

That seems a bit more complicated. Could we start with the simple path based approach, and see what happens? I suspect there will still be a performance improvement albeit a...

Okay sweet. The only other feedback I've gotten is that this is a nice first approach, but in the future it would be good to get power numbers in the...