Jianxiang Wang (王健翔)

Results 41 comments of Jianxiang Wang (王健翔)

@Maleclypse may I ask why is the numb flag reverted?

The clang-tidy error was saying that `trait_NUMB` (not `json_flag_NUMB`) was unused, so I think you should remove the definition of `trait_NUMB` rather than reverting the `json_flag_NUMB` changes.

I think you should change the following lines to use the new flags of the respective traits: https://github.com/CleverRaven/Cataclysm-DDA/blob/f2dedcb01f952a9f004e10ef9f0f051821e2a0a5/data/json/npcs/TALK_TEST.json#L97-L106 I.e. change the lines to ``` { "text": "This is a trait...

> What is in green is what you have gained due to having those proficiencies, what is in yellow is what you stand to gain from gaining that proficiency. Maybe...

> Using inverted percentages: > ![](https://user-images.githubusercontent.com/42699974/102383789-ca759780-3f80-11eb-8cb3-efd619f15f17.png) I feel that this gives a more positive vibe to it as it emphasizes "fast" and "success" instead of "long" and "failure"

The game does not use `GetTickCount64` directly so that is probably a problem with the MinGW cross compiler.

The variant list seems to be incomplete (it only contains countries starting with A to C).

This looks promising, thanks for taking the effort to do it! Could you share some screenshots of the new UIs? Also, does this allow windows and text in the SDL...

> Hard to say. When I made these changes I was not initially aware of screen readers being used in CDDA. There will probably be significant work needed to support...

I pulled the current changes and tested on SDL and Curses. I had to change a few lines of code for it to compile, so some of the results might...