Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Add national flags

Open MNG-cataclysm opened this issue 2 years ago • 9 comments

Summary

Content "Add flags of various countries"

Purpose of change

Add more flags, these are of various nations, and places where they will spawn.

Describe the solution

Add a single flag item, and add the alterations using the variants system.

Describe alternatives you've considered

Making each flag its own item, and/or adding more flags at a later date.

Testing

I spawned all the flags in, and everything works as intended.

Additional context

Unfortunately, adding images for tilesets is currently beyond my knowledge.

MNG-cataclysm avatar Nov 04 '22 16:11 MNG-cataclysm

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • It has three vertical baige, white, and green stripes.
  • It has three vertical lines navy blue, yellow, and red, overlain with the crest of Andorra.
  • It has two small stripes of red, seperated by a square of blue, with the emblem of Belize in the center.
  • It's a solid red, overlain with the crest of Albania.
  • It's divided by green and white havles, overlain with a crescent moon and a star in red.
  • It's divided by red and black rectangles, overlain by a gold machete, star, and half of a gear.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

github-actions[bot] avatar Nov 04 '22 17:11 github-actions[bot]

The variant list seems to be incomplete (it only contains countries starting with A to C).

Qrox avatar Nov 05 '22 05:11 Qrox

The variant list seems to be incomplete (it only contains countries starting with A to C).

Yes. It was getting pretty large, so I though it best to create a pull request now and add the rest of the countries later. If all 190 nations were included, the PR would greatly exceed 1200 lines.

MNG-cataclysm avatar Nov 05 '22 05:11 MNG-cataclysm

Wow, I'm so not looking forward to spriting 190 flags X) You weighted national flag slightly less than pride flag in every group, shouldn't it be the same or even a bit more likely?

Fris0uman avatar Nov 08 '22 09:11 Fris0uman

It should be "Bosnian" and not "Boznian" flag. And "Bhutanese" not "Bhutanian" flag. Probably more stuff like this but I'm a bit lazy.

KittyTac avatar Nov 10 '22 01:11 KittyTac

It should be "Bosnian" and not "Boznian" flag. And "Bhutanese" not "Bhutanian" flag. Probably more stuff like this but I'm a bit lazy.

I fixed the grammar for those two flags.

MNG-cataclysm avatar Nov 14 '22 14:11 MNG-cataclysm

Wow, I'm so not looking forward to spriting 190 flags X) You weighted national flag slightly less than pride flag in every group, shouldn't it be the same or even a bit more likely?

I wouldn't think so. I doubt many people have flags of foreign countries, at least from what I've seen.

MNG-cataclysm avatar Nov 14 '22 14:11 MNG-cataclysm

Freezing because of the number of translation strings and sprites this adds

I-am-Erk avatar Nov 24 '22 18:11 I-am-Erk

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

github-actions[bot] avatar Dec 24 '22 20:12 github-actions[bot]