Jianxiang Wang (王健翔)
Jianxiang Wang (王健翔)
ImGUI windows can only be rendered on top of everything else. Migrating the NPC dialogue window to ImGUI should fix it.
Just to be clear, the height was changing with the content even before #73455; I only moved the window to the bottom so the terrain around the player can be...
> use git diff to get the amount of changes in a PR Maybe add the ignore whitespace option? As noted in previous discussion some PRs may simply change the...
> you mean like, someone makes a PR without using the formatters, and it appears like they changed a lot? or just large indentation changes, that sounds like something you...
Looks good to me, thanks for fixing it! I'm a bit surprised this hasn't been caught by static analysis though...
Don't forget the ATM and gas pumps. Death mobile drivers would be mad though. (Maybe we can allow the player to power vending machines and gas pumps with their own...
> There's many vending machines in labs, old and new, and those still have functioning lights and computers. Makes no sense if those don't work when the power there clearly...
It might also make sense to toggle the no-translation flag inside the translation class so that the strings are not passed to translation functions.
It seems I cannot manually request non-collaborators for review, so yes you probably don't have permission to request review from non-collaborators in the first place. It also says so in...
Not sure if it is already doing this, but we can cache the item location of the last used tool and first check if the tool still exists and satisfies...