Stephen Belanger

Results 292 comments of Stephen Belanger

I've been gradually making my way through it when I have time but...it's _a lot_. 😅 I really wish we didn't discourage refactoring without an actual feature deliverable because there's...

I'm still not done reading through all of it. Like I said, it's taking a lot of time. 😅

That was how it worked originally, but people didn't like the idea of issues in that code interfering with core behaviour. I think the specialized error idea is better than...

I think it needs to be decided if the publisher should have to explicitly support being aborted/interrupted or if it should be considered a universal feature that a publish could...

There's likely many places currently which do not expect to throw internally and would therefore potentially raise an exception up to an `uncaughtException` rather than, for example, reaching a callback....

The intent is not to interrupt other subscribers, it is to interrupt the publisher. For example, if you tried to `fs.readFile(...)` the `passwd` file it could throw some error denying...

As the one that originally _wrote_ the diagnostics_channel stuff, this was very much on my mind when designing it, but we chose to simplify at the time because the specifics...

I think it's reasonable given that abort support should be left as a choice to the publisher if they wish to support it that it just be a suggested pattern...

We currently have [this section](https://nodejs.org/api/diagnostics_channel.html#tracingchannel-channels) explaining the TracingChannel pattern. You could write something similar for making things abortable.