Stephen Belanger

Results 292 comments of Stephen Belanger

Will you be at the collab summit next week? We have a diagnostics session on the agenda so we could bring it up there if you're around. :)

You can watch https://github.com/openjs-foundation/summit/ for future summits. :)

@rochdev Given the `apm:$module:$action:$event` pattern our channels are following, should the pool related ones be like `apm:pg:pool-connect:...` rather than `apm:pg-pool:connection:...`? Similar thought on the span names.

Yes, feel free to update the PR and we can have another look at it. 😃

The whole _point_ of using standard is to not debate style issues and just adopt what it says, so if we go and carve out a bunch of exceptions that...

Apparently I completely missed that #4032 already existed. We could just land _that_ if you prefer how it did things. 🤔

Also worth considering that as this no longer depends on `async_hooks` in any way it might make sense to give it a separate module name at some point too and...

Some additional notes: - ~This will have to be behind a build flag because of a conflict with Chromium using the same single-tenant API in Electron.~ - ~I have not...

Another note: This currently uses a model of building a linked-list of AsyncContextFrames which each contain only the key and value they were constructed with. The alternative which is what...