Stephen Belanger

Results 292 comments of Stephen Belanger

Thenables propagation fix is here: https://chromium-review.googlesource.com/c/v8/v8/+/4674242

@mcollina Could do that. Though the way in which we land it is still not entirely decided. Due to the Electron conflict it needs build-flagging anyway, so this could be...

I've got all but ~four~ two of the existing tests passing at this point: - ~thenables~ I have [a fix for this here](https://chromium-review.googlesource.com/c/v8/v8/+/4674242). - `http.Agent`, which I haven't yet figured...

The `SetContinuationPreservedEmbedderData` API stores a `v8::Value` in the `v8::Context`. Whenever a promise reaction job is created (meaning when it resolves or rejects) it captures the value held at that time...

I've got all the tests passing locally. Moved out of draft so I can run the full CI. I haven't done any benchmarking yet and I know there is for...

Looks like everything in full CI is working on at least one of those attempts. Not going to bother trying to outrun the flakes for a full green run before...

I deleted my prior comment with benchmark results. Turns out my build config was getting cached and I was measuring with the wrong build flag state and thus using the...

I'm not sure if they fit within the GC rules of fast-calls. They conceptually should not be allocating, but I'm unclear if the assignment or extraction from the native context...

I've added a commit which includes the addition of TurboFan builtins in V8. I'll have to get a change for that upstreamed before landing this, but just pushing to show...

There's one final remaining issue which is context leaking. The `parallel/test-async-local-storage-contexts.js` test is testing that each context gets its own separate AsyncLocalStorage graph even if the constructor or instance has...