Stephen Belanger

Results 292 comments of Stephen Belanger

I've now got the builtins working against active context rather than creation context. With that all existing tests are now passing. Final benchmark results are: ``` confidence improvement accuracy (*)...

I've submitted a [V8 CR to add the TurboFan builtins for the get/set functionality](https://chromium-review.googlesource.com/c/v8/v8/+/4809882). I'm also still waiting for reviews on the [thenables fix](https://chromium-review.googlesource.com/c/v8/v8/+/4674242). Feel free to review/comment on either....

Not currently, no. It shouldn't be too hard to make it accept a custom `http.Agent` instance though and just swap in [http-proxy-agent](https://www.npmjs.com/package/http-proxy-agent). 🤔 PRs are, of course, welcome. 😉

Happy to help. Sorry we don't support this yet. 😅

Definitely overlaps with the plugin, though this is more limited to just producing a trace around a request whereas the plugin gives a bit more control. This might benefit from...

> I think instrumentation hooks such as these should be in core. They provide a way for other instrumentations to do things via a specific plugin or wrapping package. If...

The use case for aborting is security products identifying attacks and aborting the requests early.

This appears to have already been done so closing this.

Not currently planned, as far as I'm aware. @rochdev should we make a proper feature request for this?

Yep, for exactly this reason there's been a bunch of discussion in Node.js core about a more performant replacement for AsyncLocalStorage which does not use async_hooks internally. There's unfortunately no...