ccextractor icon indicating copy to clipboard operation
ccextractor copied to clipboard

Add SCC support for CEA-708 Decoder

Open voidash opened this issue 2 years ago • 4 comments

In raising this pull request, I confirm the following (please check boxes):

  • [x] I have read and understood the contributors guide.
  • [x] I have checked that another pull request for this purpose does not exist.
  • [x] I have considered, and confirmed that this submission will be valuable to others.
  • [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • [x] I give this submission freely, and claim no ownership to its content.
  • [x] I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • [ ] I have never used CCExtractor.
  • [x] I have used CCExtractor just a couple of times.
  • [ ] I absolutely love CCExtractor, but have not contributed previously.
  • [ ] I am an active contributor to CCExtractor.

When SCC was extracted from MOV file, the SCC file was empty. So in order to fix that this pull request is being made. The exact issue it fixes is #1426 .Now SCC can be extracted from the sample video provided in the issue. Also It might be worth mentioning that the SCC caption type is pop on.

voidash avatar Apr 15 '22 02:04 voidash

Please fix the formatting issues by running clang-format and rustfmt

PunitLodha avatar Apr 16 '22 06:04 PunitLodha

Any idea why this PR isn't merged? Is there some work left?

ArchitBhonsle avatar Mar 05 '23 16:03 ArchitBhonsle

Any idea why this PR isn't merged? Is there some work left?

If I remember correctly, @voidash disappeared

cfsmp3 avatar Mar 05 '23 16:03 cfsmp3

Any idea why this PR isn't merged? Is there some work left?

@ArchitBhonsle If you test this PR, you'll see that the SCC header is being repeated for each subtitle line

PunitLodha avatar Mar 14 '23 22:03 PunitLodha

Closing since @voidash seems to have vanished and there's merge conflicts and @IshanGrover2004 has been working on this anyway.

cfsmp3 avatar Mar 03 '24 17:03 cfsmp3