Keags

Results 227 comments of Keags

> I wonder where you get the inspiration for these library functions, these functions are almost suitable for a general golang library using generics ? Years of writing Haskell as...

Here is what needs to happen in this project overall. We will focus on each step *individually*. Do not do more than the required scope for each PR. Each step...

> What about if we still have their blob on file but no active channels with the peer? I think we should still send it since it has not been...

> In the mean time I would create a separate PR for the changes I made to the brontide test, so that, that can be merged, code health+ ? Yeah...

> I created a different branch and dropped the irrelevant commits. I do not know if there is a better way to do this. I have tagged you on the...

> I do not know if we should use terms like "rate limit" and DOS to describe this then. It does not convey the true intent. We can just say:...

The approach you're looking for is to require a channel read from a `Ticker` but rather than writing every time the ticker fires, you let it buffer and sit there...

> Looks like the last three commits can be merged 🤔 🫡

> There may be more small cleanups to pull out of there if you're interested. https://github.com/lightningnetwork/lnd/pull/7210 @morehouse Big fan of the goal of your PR. Would you be interested in...

Can you explain why having a value lower than the dust limit would fix your UX problems? We can't (shouldn't?) create an output that is lower than the dust limit,...