Keags
> Haven't reviewed the code, just wanna say maybe we could update the ruleset [here](https://github.com/lightningnetwork/lnd/rules/175824) so you can push branches and change the base branch so it's easier to review....
> While we're in the business of pulling things out into prefactors, how about pulling out https://github.com/lightningnetwork/lnd/commit/3634cbafbc1d191a44ac4df2315cddad432ace0e and https://github.com/lightningnetwork/lnd/commit/8ccdbfd491f700c427376ba9df0bbfb33c6d2af9 into a trivial PR as [suggested](https://github.com/lightningnetwork/lnd/pull/8270/commits/3634cbafbc1d191a44ac4df2315cddad432ace0e#r1688008752) by @yyforyongyu? #8962 is served....
All comments addressed. The code is substantially different. I recommend a full review. Only a handful of comments were contested as opposed to accepted. Feel free to consult those threads...
> Add PackageProcedure to backup api such that a service can estimate how much data to back up. Ideally, allow it to mount read-only to the backup target so it...
No I am not challenging that it is useful to the user, I'm challenging that devs will opt to do the work of computing how much data will need to...
That's my point exactly. While it is unlikely that any backup action will *expand* the volume data during the backup process, it is technically possible to do so. Due to...
How would you go about implementing it? I'm curious.
Currently the logic assumes as axiom that the current version of the viewed service is pinned. I think removing this assumption during the computation of suggestions for actions that will...
> If it's closing_tx_1, we need to broadcast kickoff_tx first. If it's closing_tx_2, we can save one tx. Paging @Roasbeef and @jharveyb for confirmation, but I believe if we do...
Did some digging and found this in the [TAP channel bLIP](https://github.com/lightning/blips/pull/29/files): > As the Taproot Assets protocol is a overlay system on top of the Taproot script template, the impact...